[3.x] UPD deprecated getQuery(true)#311
[3.x] UPD deprecated getQuery(true)#311tkuschel wants to merge 1 commit intojoomla-framework:3.x-devfrom
Conversation
|
Changing the Interface can't be done in 3.x, also the call to $this->getQuery(true); can't be changed here because it would also be a b/c break. So this has to be moved to 4.0 |
|
Can we add the printing backtrace file only? - for 3.x -- this is a great help when debugging |
|
Not sure if this is a great idea, mainly for performance reasons, getting the stacktrace for each query call in production doesn't sounds great for me. |
|
You are right performance decreases, when dealing with that, I can manually include that code during the replacements in my code. |
|
I keep this open and added it to the next framework maintainers meeting. |
|
Move Interface change to 4.0 and don't change the deprecation message using backtrace. |
richard67
changed the title
|
Thank you for your work. With the work in #325, this change here isn't exactly necessary anymore. I'm sorry that it took this long. I'm closing this PR. |
3 participants
I am currently in the process of replacing the obsolete function getQuery(true) with createQuery() in Joomla CMS, see joomla/joomla-cms#42344 (work in progress, at the meantime it is a closed PR, but open again after testing here).
To make my life easier, I have added the interface to the database with the createQuery() on the one hand, on the other hand you can use a little trick to build in a backtrace in the output via trigger_deprecated(), so that with the help (I use code OSS under Linux Arch) of the debugger (DEBUG CONSOLE) you can immediately jump to the calling file. See attached screenshot.
The former deprecated message was also very unclear and I have reworded it.
Perhaps other deprecated messages can also be modified accordingly?
Summary of Changes
Testing Instructions
Debug messages at the DEBUG CONSOLE or log file for Deprecated API in Joomla CMS.
Documentation Changes Required
I don't know if this is not already sufficiently documented.